Add api_identifier as an accepted configurable #261
Merged
+98
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I'd like to fetch a api token with audience that my api identifier.
When I use auth0 with custom domain, I need to specify an audience that is different than the domain.
But I can not unable to do this now.
The
:audience
parameter is synonymous with the OIDC ID Token and is also used to generate the login URL, so it's confusing.Auth0's Client Credentials Flow asks the audience for an API identifier.
:custome_domein
and:sub
were suggested at #189 , but I thought there was a more direct way to express it.so I think the parameter
:api_identifier
is not confusing, What are your thoughts?References
This issue has been discussed at #189 as well.
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist