Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2718] New Actions endpoints #293

Merged
merged 2 commits into from
Sep 1, 2021
Merged

[SDK-2718] New Actions endpoints #293

merged 2 commits into from
Sep 1, 2021

Conversation

davidpatrick
Copy link
Contributor

Changes

Adds new Actions endpoints

@davidpatrick davidpatrick requested a review from a team as a code owner August 22, 2021 21:20
@davidpatrick davidpatrick added review:small Small review review:medium Medium review and removed review:small Small review labels Aug 22, 2021
evansims
evansims previously approved these changes Aug 23, 2021
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice work

evansims
evansims previously approved these changes Aug 28, 2021
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments inline, but I also notice this is missing support for the Get an action's versions endpoint? Just an oversight?

lib/auth0/api/v2/actions.rb Outdated Show resolved Hide resolved
lib/auth0/api/v2/actions.rb Outdated Show resolved Hide resolved
lib/auth0/api/v2/actions.rb Show resolved Hide resolved
jimmyjames
jimmyjames previously approved these changes Sep 1, 2021
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once coverage checks fixed

@davidpatrick davidpatrick added this to the vNext milestone Sep 1, 2021
@davidpatrick davidpatrick merged commit 0fd2dcc into master Sep 1, 2021
@davidpatrick davidpatrick deleted the actions branch September 1, 2021 18:51
@Norio4 Norio4 mentioned this pull request Sep 3, 2021
@davidpatrick davidpatrick mentioned this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants