Deprecate change_password in favor of reset_password #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `change_password` took a password argument that was only supported on legacy tenants with the flag `change_pwd_flow_v1` enabled. In order to resolve confusion, we're introducing a new method `reset_password` to fire off a password reset email, and deprecating the old method.
evansims
reviewed
Sep 9, 2021
| # @param password [string] User's new password; empty to trigger a | ||
| # password reset email | ||
| # @param password [string] User's new password. This is only available | ||
| # on legacy tenants with the change_pwd_flow_v1 flag enabled |
There was a problem hiding this comment.
Honestly not sure, but do we expose the flag identifier anywhere in a customer-facing fashion? If not, it might be better to identify this as the "Change Password Flow" toggle indicated in their tenant account settings, under the advanced tab: if v2 is enabled it's locked out for them.
|
Question aside LGTM |
evansims
previously approved these changes
Sep 9, 2021
evansims
approved these changes
Sep 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
change_passwordtook a password argument that was only supported on legacy tenants with the flagchange_pwd_flow_v1enabled. In order to resolve confusion, we're introducing a new methodreset_passwordto fire off a password reset email, and deprecating the old method.Fixes #292