Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: delete_organizations_members does not send members in body #345

Merged
merged 1 commit into from
Jun 21, 2022
Merged

FIX: delete_organizations_members does not send members in body #345

merged 1 commit into from
Jun 21, 2022

Conversation

T-800
Copy link
Contributor

@T-800 T-800 commented Jun 19, 2022

Problem

RestClient.delete "https://tinypulse-dev.us.auth0.com/api/v2/organizations/org_RuiZ53NZmzht7toO/members?members[]=auth0%7C90262", "Accept"=>"*/*", "Auth0-Client"=>"...", "Authorization"=>"Bearer ...", "Content-Type"=>"application/json", "User-Agent"=>"rest-client/2.1.0 (darwin21.4.0 aarch64) ruby/2.6.10p210"
# => 400 BadRequest | application/json 149 bytes, 0.40s
Auth0::BadRequest ({"statusCode":400,"error":"Bad Request","message":"Payload validation error: 'Expected type object but found type null'.","errorCode":"invalid_body"})

Changes

  • Use delete_with_body instead of delete for delete_organizations_members to send body

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of Ruby

Checklist

@T-800 T-800 requested a review from a team as a code owner June 19, 2022 23:16
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@stevehobbsdev stevehobbsdev merged commit 19dc770 into auth0:master Jun 21, 2022
@stevehobbsdev stevehobbsdev mentioned this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants