Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

email validation is broken by _, which breaks the tests #35

Merged
merged 1 commit into from
Jul 9, 2015
Merged

email validation is broken by _, which breaks the tests #35

merged 1 commit into from
Jul 9, 2015

Conversation

taylorfinnell
Copy link
Contributor

Tests were throwing this (integration tests)

 Failure/Error: let!(:user) { client.create_user(email, password, connection, {
     Auth0::BadRequest:
       {"error"=>"bad.email", "error_description"=>"error in email - email format validation failed: [email protected]"}

@taylorfinnell
Copy link
Contributor Author

Can this be merged soon? Integration tests are straight up broken in master without this code, as far as I know.

hzalaz added a commit that referenced this pull request Jul 9, 2015
@hzalaz
Merge pull request #35 from taylorfinnell/fix_email_validation_error_…
49baa34 
…in_tests

email validation is broken by _, which breaks the tests
@hzalaz hzalaz merged commit 49baa34 into auth0:master Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taylorfinnell @hzalaz