Make delete user safe #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id has the form "auth0|foo123", Ruby URI doesn't like "|".
POST /api/users/ is another API call – which will remove all users, don't want that to happen unexpectedly!
|
@jfromaniello @mgonto what do you think? |
|
sorry for the delay, I think all the PR looks great :) Thank you very much for these contributions we will merge and push today |
|
Looks awesome :). Thanks for the contribution! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If id is an empty string, the call will look like
which is another API call – to remove all users – we sure don't want that to happen unexpectedly.