[SDK-4546] Add orgs in client credentials support #540
Conversation
| page: options.fetch(:page, nil), | ||
| include_totals: options.fetch(:include_totals, nil) | ||
| } | ||
| path = "#{organizations_client_grants_path(organization_id)}" |
There was a problem hiding this comment.
Is it necessary to interpolate the return value, if organizations_client_grants_path(organization_id) returns a string?
There was a problem hiding this comment.
Maybe not? Am just being consistent with the rest of the file https://github.com/auth0/ruby-auth0/pull/540/files/43bb301afee4d5ebd923eb897b53b998bc3465b6#diff-3936cbc470adbe60f39a627f01d4259b0c1121de790b4e7d3144c536f073ccf7R324
| body = {} | ||
| body[:grant_id] = grant_id | ||
|
|
||
| path = "#{organizations_client_grants_path(organization_id)}" |
There was a problem hiding this comment.
Same as before, is the string interpolation necessary?
There was a problem hiding this comment.
Same as before, just being consistent...
| @@ -11,13 +11,15 @@ module ClientGrants | |||
| # @param audience [string] The audience of the client grant to retrieve. | |||
| # @param page [int] Page number to get, 0-based. | |||
| # @param per_page [int] Results per page if also passing a page number. | |||
| # @param allow_any_organization [bool] Optional filter on allow_any_organization. | |||
There was a problem hiding this comment.
Should we expand a bit on what allow_any_organization does?
There was a problem hiding this comment.
I'd agree if you were getting/setting the allow_any_organization field, but this is a filter on the value
adamjmcgrath
changed the title
Co-authored-by: Rita Zerrizuela <[email protected]>
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
Co-authored-by: Rita Zerrizuela <[email protected]>
Co-authored-by: Rita Zerrizuela <[email protected]>
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
Changes