Add create user method #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will raise exception and echo the error message from the API if the call wasn't successful.
|
@jfromaniello @mgonto what do you think? |
| }.to_json | ||
| }) | ||
|
|
||
| if response.code == 200 |
There was a problem hiding this comment.
We should check here for any valid status I think. 201 would be good as well
|
Thanks for the contribution. It looks good. Do you think there's any chance you could use VCR or something like that to add some tests. We'd greatly appreciate that :D. Anyway, please rebase with master to merge. Thanks! |
|
Sorry for the delay, I had to prioritize other things. I will close this as it's covered by #9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for creating a user.
Will raise exception and echo the error message from the API if the call wasn't successful.