Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting secret_base64_encoded as false causes an exception #18

Closed
mickadoo opened this issue Nov 15, 2015 · 2 comments
Closed

Setting secret_base64_encoded as false causes an exception #18

mickadoo opened this issue Nov 15, 2015 · 2 comments

Comments

@mickadoo
Copy link
Contributor

In the jwt_auth configuration block setting secret_base64_encoded to false throws a InvalidConfigurationException with the message

The path "jwt_auth.secret_base64_encoded" cannot contain an empty value, but got false.

Since the default is true, this means I can't set secret_base64_encoded to be false.
@mickadoo mickadoo mentioned this issue Nov 15, 2015
Merged
@glena
Copy link
Contributor

glena commented Nov 16, 2015

good catch, I will merge and make the release tomorrow.
Thanks

@glena glena closed this as completed Nov 17, 2015
glena added a commit that referenced this issue Nov 17, 2015
@glena
Merge pull request #19 from mickadoo/18_allow-unencoded-secret
b18c44d 
[#18] Remove "cannotBeEmpty" property of secret_base64_encoded
@glena
Copy link
Contributor

glena commented Nov 17, 2015

And v1.2.6 it is.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glena @mickadoo