fetch git tags so that trivy sees the right binary version #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
vroldanbet
force-pushed
the
fix-trivy-goreleaser
branch
2 times, most recently
from
8ad7e15 to
01fb59e
Compare
vroldanbet
changed the title
vroldanbet
force-pushed
the
fix-trivy-goreleaser
branch
2 times, most recently
from
3fe79ed to
b083c0b
Compare
ecordell
previously approved these changes
May 3, 2024
ecordell
reviewed
May 3, 2024
| @@ -42,6 +42,8 @@ jobs: | |||
| runs-on: "buildjet-2vcpu-ubuntu-2204" | |||
| steps: | |||
| - uses: "actions/checkout@v4" | |||
| with: | |||
| fetch-depth: 0 | |||
There was a problem hiding this comment.
should this be fetch-tags or does this work?
There was a problem hiding this comment.
Only a single commit is fetched by default, for the ref/SHA that triggered the workflow. Set fetch-depth: 0 to fetch all history for all branches and tags. Refer here to learn which commit $GITHUB_SHA points to for different events.
We should add a comment to this line
There was a problem hiding this comment.
should this be fetch-tags or does this work?
@ecordell I tried that first. For some reason that didn't work. Could be an issue with the GH action, so I went the easy route
There was a problem hiding this comment.
this fixes an issue with trivy where it flags SpiceDB as vulnerable, possibly as of aquasecurity/trivy#6564 include in version 0.51.0. It's flagged because it parses it as version 0.0.1-next as generated by goreleaser, because it does not have the tags available
vroldanbet
force-pushed
the
fix-trivy-goreleaser
branch
from
b083c0b to
7643701
Compare
ecordell
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes an issue with trivy where it flags SpiceDB as vulnerable, possibly as of aquasecurity/trivy#6564 include in version 0.51.0. It's flagged because it parses it as version 0.0.1-next.
Because the
checkoutaction does not fetch the tags by default, goreleaser is unable the generate the right version.