Unlock the certificate renewal lock when allow_domain returns false #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gohai
changed the title
All other early returns in renew_check_cert drop this lock. Would warrant a comment if this is not needed here.
gohai
force-pushed
the
renew-allow_domain-locking
branch
from
2c98977 to
c263c52
Compare
|
Ah, great catch, thank you very much! |
|
Can you cut a release with this fix please? |
|
@emersonf: Sorry for the delay. I'll try to get a new release done this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other early returns in renew_check_cert drop this lock. Would warrant a comment if this is not needed here.