-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetConstructorMatchingParameterNames #45
GetConstructorMatchingParameterNames #45
Conversation
… available parameters. If no such constructor found, default to GetMostParametersConstructor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #45 +/- ##
===========================================
+ Coverage 64.81% 65.54% +0.72%
===========================================
Files 11 11
Lines 378 386 +8
Branches 118 119 +1
===========================================
+ Hits 245 253 +8
Misses 70 70
Partials 63 63 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes themselves look awesome - no notes!
Is there a way to add a unit test that will validate that this works and/or possibly falls back to the default behavior? That way if someone in the future wants to make a change, we make sure they don't break what you've done here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks! I'll try to get a release out soon.
Solves #44 by trying to get a constructor that matches the available parameters. If no such constructor found, default to GetMostParametersConstructor