Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uniffi_automerge to be consumed as a crate dependency #202

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

kateinoigakukun
Copy link
Contributor

Currently two static libraries generated by a Rust toolchain cannot be linked together in a single binary due to symbol conflicts (see rust-lang/rust#104707). This is a problem for WebAssembly targets, where dynamic linking is not stable yet. To link multiple Rust-originated static libraries together, we need to produce a single static library from an umbrella crate that re-exports everything from its dependencies.

This change allows uniffi_automerge to be consumed as a crate dependency by the umbrella crate.

Currently two static libraries generated by a Rust toolchain cannot be
linked together in a single binary due to symbol conflicts (see
rust-lang/rust#104707). This is a problem for
WebAssembly targets, where dynamic linking is not stable yet. To link
multiple Rust-originated static libraries together, we need to produce
a single static library from an umbrella crate that re-exports everything
from its dependencies.

This change allows `uniffi_automerge` to be consumed as a crate dependency
by the umbrella crate.
@heckj heckj requested review from heckj and alexjg November 18, 2024 16:30
Copy link
Collaborator

@heckj heckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks completely fine to me, but I'm less than familiar with any possible implications. @alexjg Could you look this over and weigh in as well?

@kateinoigakukun
Copy link
Contributor Author

@alexjg Gentle ping :)

Copy link
Collaborator

@alexjg alexjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@heckj heckj merged commit 9bb3b5f into automerge:main Dec 5, 2024
5 checks passed
@kateinoigakukun
Copy link
Contributor Author

Thank you all!

@heckj
Copy link
Collaborator

heckj commented Dec 5, 2024

Thanks for the contribution Yuta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants