Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent naming for loggers #159

Closed
mfeurer opened this issue Jan 23, 2017 · 1 comment
Closed

Use consistent naming for loggers #159

mfeurer opened this issue Jan 23, 2017 · 1 comment
Assignees
@shukon

Comments

@mfeurer
Copy link
Contributor

mfeurer commented Jan 23, 2017

Currently, loggers have names like:

  • localsearch
  • intensifier
  • SMBO

This makes it hard to disable them in applications building on SMAC. Having names like

  • smac.smbo.Localsearch
  • smac.intensify.Intensifier

etc. would make it easier to set a log level for the whole SMAC package and/or set the log level for a submodule of SMAC.
@shukon
Copy link
Collaborator

shukon commented Feb 10, 2017

Changed names (I hope I got them all) in branch issue/#159. Not sure how/whether to add functionality for setting log-levels.

@shukon shukon self-assigned this Feb 10, 2017
@coveralls coveralls mentioned this issue Feb 14, 2017
Merged
mlindauer added a commit that referenced this issue Mar 15, 2017
@mlindauer
Merge pull request #180 from automl/issue/#159
186f113 
Issue/#159 - consistent names for loggers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shukon shukon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mfeurer @mlindauer @shukon