fix bug in uncorrelated_mo_rf_with_instances, improve tests #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreBiedenkapp
approved these changes
Oct 27, 2017
mlindauer
approved these changes
Oct 27, 2017
Codecov Report
@@ Coverage Diff @@
## development #333 +/- ##
===============================================
+ Coverage 90.12% 90.13% +0.01%
===============================================
Files 45 45
Lines 2857 2860 +3
===============================================
+ Hits 2575 2578 +3
Misses 282 282
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the previous implementation expected the
BaseEPMand theRandomForestWithInstancesto accept the same arguments. This is apparently wrong and fixed in this PR.