Download pieces in batches for piece cache sync #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
force-pushed
the
batched-piece-cache-sync
branch
from
00ac3b2 to
52c5731
Compare
teor2345
approved these changes
Oct 20, 2024
| self.handlers.progress.call_simple(&progress); | ||
| } | ||
| })); | ||
| // Download two batches concurrently to make sure slow tail of one is compensated by another |
There was a problem hiding this comment.
Suggested change
| // Download two batches concurrently to make sure slow tail of one is compensated by another | |
| // Download four batches concurrently to make sure slow tail of one is compensated by another |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more thing remained, the thing users complained about: piece cache sync.
This implements batched downloads, but only for initial sync. I was lazy to do it for keep-up sync right now and keep-up sync is much less critical.
Hit another one of the sub-issues of rust-lang/rust#110338 that I don't think I hit before, so had to waste a bit of time and do some unfortunate allocations to make it compile.
A lot of changes here are simply due to code being offset to the right.
Code contributor checklist: