feat(api/c-chain): change of behavior for eth_getProof #1996
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| Note the `eth_getProof` is acting differently from release v0.14.1: | ||
|
|
||
| - On archive nodes (`"pruning-enabled": false`): queries for historical proofs for state older than approximately 24 hours preceding the last accepted block will be rejected by default. This can be adjusted with the new option `historical-proof-query-window` which defines the number of blocks before the last accepted block which should be accepted for state proof queries, or set to `0` to accept any block number state query. | ||
| - On `pruning` nodes: queries for proofs past the tip buffer (32 blocks) will be rejected |
There was a problem hiding this comment.
this is the same (except the error message I suppose) as the previous behavior isn't it? 🤔
If it is, should we remove it from here?
There was a problem hiding this comment.
It's not the exact same behavior as they would have responded to proofs for blocks matching the commit height 4096, so we can leave this here.
Also perhaps this should be under the Ethereum APIs section, we can add a new section for eth_getProof if there's not one already and just include this notice, mentioning the API otherwise behaves as upstream.
There was a problem hiding this comment.
It's already in the ## Ethereum APIs section / ### Standard Ethereum APIs sub-section.
I've moved this to an #### Exceptions subsection as a bullet point, let me know if that works.
qdm12
force-pushed
the
qdm12/api/c-chain/eth_getProof
branch
from
cd874a5 to
2101c6e
Compare
| @@ -81,6 +81,14 @@ For batched requests on the [public API node](/tooling/rpc-providers) , the maxi | |||
| number of items is 40. We are working on to support a larger batch size. | |||
| </Callout> | |||
|
|
|||
| #### Exceptions | |||
|
|
|||
| - `eth_getProof` behaves differently than geth, from release v0.14.1, with the following differences: | |||
There was a problem hiding this comment.
the release version should the avalanchego version, not the coreth version. I suppose we should wait for the next avalanchego release using coreth v0.14.1 (unreleased) to merge this PR.
qdm12
added
the
DO NOT MERGE
|
I am surprised this doesn't need a rebasing |
qdm12
removed
the
DO NOT MERGE
Co-authored-by: Meaghan FitzGerald <[email protected]> Signed-off-by: Quentin McGaw <[email protected]>
Signed-off-by: Quentin McGaw <[email protected]>
qdm12
force-pushed
the
qdm12/api/c-chain/eth_getProof
branch
from
119671f to
cda0685
Compare
No description provided.