Skip to content

Commit

Permalink
fixup: Respond to review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
maru-ava committed Jan 3, 2024
1 parent 10dc9d9 commit 122a88a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
9 changes: 3 additions & 6 deletions tests/fixture/tmpnet/network.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ import (
"github.com/ava-labs/avalanchego/utils/set"
)

// The Network type is defined in this file (network.go - orchestration) and
// network.go (reading/writing configuration).
// The Network type is defined in this file (orchestration) and
// network_config.go (reading/writing configuration).

const (
// Constants defining the names of shell variables whose value can
Expand Down Expand Up @@ -245,10 +245,7 @@ func (n *Network) StartNode(ctx context.Context, w io.Writer, node *Node) error
if err := node.Start(w); err != nil {
// Attempt to stop an unhealthy node to provide some assurance to the caller
// that an error condition will not result in a lingering process.
stopErr := node.Stop(ctx)
if stopErr != nil {
err = errors.Join(err, stopErr)
}
err = errors.Join(err, node.Stop(ctx))
return err
}

Expand Down
4 changes: 2 additions & 2 deletions tests/fixture/tmpnet/network_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ import (
"github.com/ava-labs/avalanchego/utils/perms"
)

// The Network type is defined in this file (network_config.go - reading/writing configuration) and
// network.go (network.go - orchestration).
// The Network type is defined in this file (reading/writing configuration) and network.go
// (orchestration).

var errMissingNetworkDir = errors.New("failed to write network: missing network directory")

Expand Down

0 comments on commit 122a88a

Please sign in to comment.