merkledb -- dynamic root
#2177
Merged
merkledb -- dynamic root
#2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
October 17, 2023 12:37
| @@ -51,11 +51,11 @@ var ( | |||
| intermediateNodePrefix = []byte{2} | |||
|
|
|||
| cleanShutdownKey = []byte(string(metadataPrefix) + "cleanShutdown") | |||
| rootDBKey = []byte(string(metadataPrefix) + "root") | |||
There was a problem hiding this comment.
realized belatedly that you don't actually need this since the root should always be the smallest key present in your nodes db. You should be able to just grab the first key on the iterator, right?
There was a problem hiding this comment.
We could do that, but I feel like this is a bit cleaner than having to check both the value and intermediate node databases
There was a problem hiding this comment.
The current code still checks both dbs
| @@ -249,6 +254,13 @@ func (th *trieHistory) getChangesToGetToRoot(rootID ids.ID, start maybe.Maybe[[] | |||
| for i := mostRecentChangeIndex; i > lastRootChangeIndex; i-- { | |||
| changes, _ := th.history.Index(i) | |||
|
|
|||
| if i == mostRecentChangeIndex { | |||
There was a problem hiding this comment.
should these just be outside the loop?
There was a problem hiding this comment.
They could be, but then we'd end up having to get it from th.history again anyway, so I don't think that'd really buy us anything
added 8 commits
December 11, 2023 14:46
danlaine
force-pushed
the
merkledb-dynamic-root
branch
from
5a316b7 to
473a264
Compare
danlaine
force-pushed
the
merkledb-dynamic-root
branch
from
5023fb8 to
7963a0b
Compare
dboehm-avalabs
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The
rootfield of atrieViewor the database should be the actualroot.How this works
rootis now amaybe.Maybe[*node]which isNothingiff the trie is empty.ids.Emptyroot ID iff the trie is empty.changeSummarynow explicitly tracks therootChange.trieviewtherootis now the actual root of the trie.getPathTomay now return an empty path.How this was tested
Update existing and add new UT.