Make messageQueue.msgAndCtxs a circular buffer
#2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
approved these changes
Dec 6, 2023
joshua-kim
reviewed
Dec 6, 2023
| @@ -85,6 +86,7 @@ func NewMessageQueue( | |||
| cpuTracker: cpuTracker, | |||
| cond: sync.NewCond(&sync.Mutex{}), | |||
| nodeToUnprocessedMsgs: make(map[ids.NodeID]int), | |||
| msgAndCtxs: buffer.NewUnboundedDeque[*msgAndContext](1 /*=initSize*/), | |||
There was a problem hiding this comment.
We do this in our codebase but I don't understand why... IDEs will usually display the name of the parameter and in this case it's really not needed since we only have one possible parameter
There was a problem hiding this comment.
vscode does not put in the name of the parameter (which most of the team uses)
joshua-kim
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We can remove some logic about slice manipulation. Also this should result in fewer slices being allocated.
How this works
[]*msgAndCtx-->buffer.Deque[*msgAndCtx]How this was tested
Existing UT