Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove staged timer again #2440

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Remove staged timer again #2440

merged 1 commit into from
Dec 7, 2023

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

This is dead code. This was previously introduced to patch broken downstreams (ref: 42d03c0). However, all those downstreams have either migrated or since inlined the functionality. If someone hasn't inlined the functionality and they need it, then they can inline it.

How this works

Deletes code.

How this was tested

CI

@StephenButtolph StephenButtolph added the cleanup Code quality improvement label Dec 7, 2023
@StephenButtolph StephenButtolph added this to the v1.10.18 milestone Dec 7, 2023
@StephenButtolph StephenButtolph self-assigned this Dec 7, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 7, 2023
Merged via the queue into dev with commit 7c33fa3 Dec 7, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the remove-staged-timer branch December 7, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants