Refactor sampler seeding #2456
Merged
Refactor sampler seeding #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
reviewed
Dec 10, 2023
Comment on lines
+32
to
+36
| &uniformReplacer{ | ||
| rng: globalRNG, | ||
| }, | ||
| &uniformResample{ | ||
| rng: globalRNG, |
There was a problem hiding this comment.
nit: should we use the NewUniform constructor here?
There was a problem hiding this comment.
I think that would be pretty hard to understand which concrete type we are checking for (considering both of these structs are uniform samplers).
abi87
reviewed
Dec 10, 2023
| @@ -26,29 +26,28 @@ func TestDualAlphaOptimization(t *testing.T) { | |||
| BetaVirtuous: 15, | |||
| BetaRogue: 20, | |||
| } | |||
| seed uint64 = 0 | |||
| seed uint64 = 0 | |||
| source = prng.NewMT19937() | |||
There was a problem hiding this comment.
q: should we encapsulate this within a rand.DefaultSource getter? Admittedly it'd be another global, but maybe it'd help clients select the right source of randomness?
There was a problem hiding this comment.
I don't think we really care too much about the actual randomness used... just that it is deterministic. I don't really seen the benefit in adding a helper here.
dhrubabasu
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
Rather than creating a sampler and then seeding it - we allow a custom source of RNG (which can already be seeded).
How this was tested