tmpnet: Break config.go up into coherent parts
#2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
tmpnet-refactor-config
branch
from
99909be to
e446b6a
Compare
marun
force-pushed
the
tmpnet-move-local
branch
from
3e42f16 to
184b8d8
Compare
marun
force-pushed
the
tmpnet-refactor-config
branch
from
e446b6a to
0a2ab0a
Compare
marun
changed the title
tmpnet: Break config.go up into coherent parts
marun
force-pushed
the
tmpnet-move-local
branch
2 times, most recently
from
ae08b7e to
19dca4a
Compare
marun
force-pushed
the
tmpnet-refactor-config
branch
from
0a2ab0a to
2597b74
Compare
marun
force-pushed
the
tmpnet-move-local
branch
2 times, most recently
from
e20e8f7 to
93dc814
Compare
marun
force-pushed
the
tmpnet-refactor-config
branch
from
5c35f62 to
dab364e
Compare
marun
force-pushed
the
tmpnet-move-local
branch
from
4b22d47 to
cb968e8
Compare
marun
force-pushed
the
tmpnet-refactor-config
branch
from
dab364e to
e338c6e
Compare
marun
force-pushed
the
tmpnet-refactor-config
branch
from
e338c6e to
fe08729
Compare
- Move NetworkConfig functionality to Network - Move NodeConfig functionality to Node - Move FlagsMap to flags.go - Move genesis helpers to genesis.go - Move NodeURI and key generation to utils.go - Remove redundant node_test.go
marun
force-pushed
the
tmpnet-refactor-config
branch
from
fe08729 to
205f6e8
Compare
abi87
reviewed
Dec 15, 2023
| @@ -19,6 +19,15 @@ const ( | |||
| DefaultNetworkStartTimeout = 2 * time.Minute | |||
| DefaultNodeInitTimeout = 10 * time.Second | |||
| DefaultNodeStopTimeout = 5 * time.Second | |||
|
|
|||
| // Minimum required to ensure connectivity-based health checks will pass | |||
| DefaultNodeCount = 2 | |||
There was a problem hiding this comment.
probably out of scope here but should this be MinNodeCount? And should we assert that we never have a single node network? Not sure if the latter is too restrictive for our testing.
There was a problem hiding this comment.
Funny, I had the same thought. I figured default made a bit more sense even if 2 happens to be the minimum.
I don't think anyone should be starting a single node network with the tmpnet fixture - easier to just run the binary yourself. Attempting to do so would fail by default, would require disabling sybil protection. I'm inclined to ignore that possibility until such time as it becomes a requirement.
abi87
reviewed
Dec 15, 2023
abi87
reviewed
Dec 15, 2023
abi87
reviewed
Dec 15, 2023
danlaine
approved these changes
Dec 15, 2023
6 tasks
marun
added a commit
that referenced
this pull request
Dec 20, 2023
marun
added a commit
that referenced
this pull request
Dec 21, 2023
marun
added a commit
that referenced
this pull request
Dec 22, 2023
marun
added a commit
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely mechanical reorganization to improve maintainability: