merkledb -- make tests use time as randomness seed
#2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
commented
Dec 11, 2023
| @@ -280,19 +276,7 @@ func TestGetRangeProof(t *testing.T) { | |||
| response.StartProof = proof.StartProof | |||
| response.EndProof = proof.EndProof | |||
| }, | |||
| expectedErr: merkledb.ErrInvalidProof, | |||
| }, | |||
| "removed last key in response": { | |||
There was a problem hiding this comment.
We're not guaranteed to error here. The proof might still be valid.
danlaine
commented
Dec 11, 2023
| @@ -623,19 +603,7 @@ func TestGetChangeProof(t *testing.T) { | |||
| modifyChangeProofResponse: func(response *merkledb.ChangeProof) { | |||
| response.KeyChanges = response.KeyChanges[1:] | |||
| }, | |||
| expectedErr: merkledb.ErrInvalidProof, | |||
| }, | |||
| "removed last key in response": { | |||
There was a problem hiding this comment.
We're not guaranteed to error here. The proof might still be valid.
dboehm-avalabs
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Since we use Go 1.20 now, we can wrap errors.
How this works
Use time-based randomness in tests. Remove broken tests.
How this was tested
Run the tests.