Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vms/platformvm: Add TestBuildBlockForceAdvanceTime test #2472

Merged
merged 9 commits into from
Dec 12, 2023

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

Less mocks, more real UTs

How this works

add a UT, remove a UT

How this was tested

CI

@dhrubabasu dhrubabasu added testing This primarily focuses on testing cleanup Code quality improvement labels Dec 11, 2023
@dhrubabasu dhrubabasu added this to the v1.10.18 milestone Dec 11, 2023
@dhrubabasu dhrubabasu self-assigned this Dec 11, 2023
@dhrubabasu dhrubabasu changed the base branch from dev to TestBuildBlockShouldAdvanceTime December 12, 2023 10:06
auto-merge was automatically disabled December 12, 2023 10:07

Merge commits are not allowed on this repository

Base automatically changed from TestBuildBlockShouldAdvanceTime to dev December 12, 2023 17:41
@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 12, 2023
Merged via the queue into dev with commit 7963115 Dec 12, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the TestBuildBlockForceAdvanceTime branch December 12, 2023 20:00
joshua-kim added a commit that referenced this pull request Dec 13, 2023
commit 82fbc97
Author: Stephen Buttolph <[email protected]>
Date:   Tue Dec 12 18:30:09 2023 -0500

    Add ACP signaling (#2476)

commit ac5a00e
Author: Joshua Kim <[email protected]>
Date:   Tue Dec 12 17:42:32 2023 -0500

    Refactor p2p unit tests (#2475)

    Signed-off-by: Joshua Kim <[email protected]>
    Co-authored-by: Dan Laine <[email protected]>

commit 0b2b109
Author: Dhruba Basu <[email protected]>
Date:   Tue Dec 12 16:48:28 2023 -0500

    `vms/platformvm`: Verify txs before building a block (#2359)

    Co-authored-by: Stephen Buttolph <[email protected]>

commit 4be744e
Author: Joshua Kim <[email protected]>
Date:   Tue Dec 12 15:08:48 2023 -0500

    P2P AppError handling (#2248)

    Signed-off-by: Joshua Kim <[email protected]>
    Co-authored-by: Stephen Buttolph <[email protected]>

commit 7963115
Author: Dhruba Basu <[email protected]>
Date:   Tue Dec 12 14:37:59 2023 -0500

    `vms/platformvm`: Add `TestBuildBlockForceAdvanceTime` test (#2472)

    Co-authored-by: Stephen Buttolph <[email protected]>

commit dc472ec
Author: Dhruba Basu <[email protected]>
Date:   Tue Dec 12 14:37:43 2023 -0500

    `vms/platformvm`: Permit usage of the `Transactions` field in `BanffProposalBlock` (#2451)

    Co-authored-by: Stephen Buttolph <[email protected]>

Signed-off-by: Joshua Kim <[email protected]>
pull bot pushed a commit to AKAJOKER2/avalanchego that referenced this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants