Remove nullable options #2481
Merged
Remove nullable options #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytzuga
requested review from
danlaine,
darioush,
dboehm-avalabs,
abi87,
gyuho,
marun,
hexfusion,
StephenButtolph and
joshua-kim
as code owners
nytzuga
force-pushed
the
remove-nullable-options
branch
from
7ee13dd to
37ff43e
Compare
There is no longer the need to serialize null pointers
nytzuga
force-pushed
the
remove-nullable-options
branch
from
37ff43e to
f503086
Compare
StephenButtolph
approved these changes
Dec 13, 2023
StephenButtolph
removed request for
marun,
hexfusion,
darioush,
gyuho,
abi87,
joshua-kim and
dboehm-avalabs
darioush
approved these changes
Dec 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tedim52
pushed a commit
to tedim52/avalanchego
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
There is no longer the need to serialize nil pointers since ava-labs/subnet-evm#762 is being solved with a more manual approach for serialization.
How this works
This removes the nil pointers (introduced in #2171)
How this was tested
The feature was not being used by parts of the code so it was only tested with unit tests