Remove snow.DefaultContextTest
#2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
added
testing
dhrubabasu
requested review from
hexfusion,
StephenButtolph,
abi87 and
danlaine
as code owners
abi87
reviewed
Dec 20, 2023
abi87
approved these changes
Dec 21, 2023
StephenButtolph
approved these changes
Dec 21, 2023
| @@ -96,22 +96,3 @@ type ConsensusContext struct { | |||
| // True iff this chain is currently state-syncing | |||
| StateSyncing utils.Atomic[bool] | |||
| } | |||
|
|
|||
| func DefaultContextTest() *Context { | |||
snow/snowtest/snowtest.go
Outdated
Comment on lines
41
to
58
| func EmptyContext() *snow.Context { | ||
| sk, err := bls.NewSecretKey() | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| pk := bls.PublicFromSecretKey(sk) | ||
| return &snow.Context{ | ||
| NetworkID: 0, | ||
| SubnetID: ids.Empty, | ||
| ChainID: ids.Empty, | ||
| NodeID: ids.EmptyNodeID, | ||
| PublicKey: pk, | ||
| Log: logging.NoLog{}, | ||
| BCLookup: ids.NewAliaser(), | ||
| Metrics: metrics.NewOptionalGatherer(), | ||
| ChainDataDir: "", | ||
| } | ||
| } |
There was a problem hiding this comment.
I know this is what we had before... but I still hate this... Are there places that we currently use EmptyContext that we could just be using Context?
There was a problem hiding this comment.
Removed EmptyContext altogether :)
dhrubabasu
changed the title
snow.DefaultContextTest to snowtest.EmptyContextsnow.DefaultContextTest
dhrubabasu
changed the title
snow.DefaultContextTestsnow.DefaultContextTest
StephenButtolph
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We should be using
snowtest.Context()in most places.How this works
Replace
How this was tested
CI