Make P-Chain Mempool thread-safe #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
force-pushed
the
pchain-thread-safe-mempool
branch
from
f67d1da to
9413a68
Compare
joshua-kim
commented
Dec 20, 2023
joshua-kim
requested review from
abi87,
danlaine and
StephenButtolph
as code owners
dhrubabasu
reviewed
Dec 20, 2023
dhrubabasu
reviewed
Dec 20, 2023
abi87
reviewed
Dec 20, 2023
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
abi87
reviewed
Dec 20, 2023
abi87
approved these changes
Dec 20, 2023
dhrubabasu
reviewed
Dec 21, 2023
dhrubabasu
reviewed
Dec 21, 2023
dhrubabasu
reviewed
Dec 21, 2023
dhrubabasu
reviewed
Dec 21, 2023
dhrubabasu
reviewed
Dec 21, 2023
Signed-off-by: Joshua Kim <[email protected]>
dhrubabasu
approved these changes
Dec 21, 2023
Signed-off-by: Joshua Kim <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Joshua Kim <[email protected]>
StephenButtolph
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Makes the P-Chain mempool thread-safe. Currently we use the
snow.Contextlock to synchronize access to this, but we can use a lock in the mempool struct itself and only require holding the context lock when verifying against latest state.How this works
Adds lock to the mempool
How this was tested
UTs