Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce TxVerifier interface to network #2533

Merged
merged 10 commits into from
Dec 22, 2023
Merged

Introduce TxVerifier interface to network #2533

merged 10 commits into from
Dec 22, 2023

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

Factored out of #2490.

How this works

  • Rather than having the network manage locking, this pulls the locking knowledge out into the VM.
  • Reduces the interface required to be provided to the network code.

How this was tested

  • CI

@StephenButtolph StephenButtolph added the cleanup Code quality improvement label Dec 21, 2023
@StephenButtolph StephenButtolph added this to the v1.10.18 milestone Dec 21, 2023
@StephenButtolph StephenButtolph self-assigned this Dec 21, 2023
Base automatically changed from rework-networking-issaunce to dev December 22, 2023 00:02
marun
marun approved these changes Dec 22, 2023
View reviewed changes
vms/avm/network/network_test.go Outdated Show resolved Hide resolved
@StephenButtolph StephenButtolph added this pull request to the merge queue Dec 22, 2023
Merged via the queue into dev with commit a4cfbc0 Dec 22, 2023
17 checks passed
@StephenButtolph StephenButtolph deleted the tx-verifier branch December 22, 2023 15:28
@joshua-kim joshua-kim mentioned this pull request Dec 22, 2023
Merged
pull bot pushed a commit to AKAJOKER2/avalanchego that referenced this pull request Jan 1, 2024
@abi87
Replace bool flags in P-chain state diffs with an enum (ava-labs#2533)
73b8717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-kim joshua-kim joshua-kim approved these changes

@marun marun marun approved these changes

Assignees

@StephenButtolph StephenButtolph

Labels
cleanup Code quality improvement
Projects
Platform Engineering Group
Archived in project
Milestone
v1.10.18
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @marun @joshua-kim