Fix p2p sdk metric labels #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
bug
StephenButtolph
requested review from
danlaine and
joshua-kim
as code owners
dhrubabasu
approved these changes
Dec 29, 2023
StephenButtolph
commented
Dec 29, 2023
| @@ -54,9 +49,6 @@ type Handler[T Gossipable] struct { | |||
| set Set[T] | |||
| metrics Metrics | |||
| targetResponseSize int | |||
|
|
|||
| pullLabels prometheus.Labels | |||
| pushLabels prometheus.Labels | |||
There was a problem hiding this comment.
This was the source of the bug - only pullLabels was initialized in NewHandler.
joshua-kim
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes:
How this works
Previously the
pushLabelswas incorrectly left uninitialized. This removes alllabelsfrom structs and converts them into package private global constants.How this was tested