Cleanup codec usage #2563
Merged
Cleanup codec usage #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Dec 29, 2023
| ) | ||
|
|
||
| var c codec.Manager |
There was a problem hiding this comment.
Codec is much easier to read than c and this allows easier usage of the format.
Comment on lines
+11
to
+22
| const CodecVersion = 0 | ||
|
|
||
| var Codec codec.Manager | ||
|
|
||
| func init() { | ||
| lc := linearcodec.NewDefault() | ||
| Codec = codec.NewDefaultManager() | ||
|
|
||
| if err := Codec.RegisterCodec(CodecVersion, lc); err != nil { | ||
| panic(err) | ||
| } | ||
| } |
There was a problem hiding this comment.
There was no reason we created a new codec for each encdb instance.
Comment on lines
+13
to
+24
| const CodecVersion = 0 | ||
|
|
||
| var Codec codec.Manager | ||
|
|
||
| func init() { | ||
| lc := linearcodec.NewCustomMaxLength(math.MaxUint32) | ||
| Codec = codec.NewManager(math.MaxInt) | ||
|
|
||
| if err := Codec.RegisterCodec(CodecVersion, lc); err != nil { | ||
| panic(err) | ||
| } | ||
| } |
There was a problem hiding this comment.
There was no reason we created a new codec for each indexer.
|
|
||
| func init() { | ||
| lc := linearcodec.NewCustomMaxLength(math.MaxUint32) | ||
| Codec = codec.NewManager(math.MaxInt) |
There was a problem hiding this comment.
There was no reason to have a complex calculated maximum length here.
|
|
||
| func init() { | ||
| lc := linearcodec.New([]string{reflectcodec.DefaultTagName + "V0"}, maxSize) | ||
| lc2 := linearcodec.New([]string{reflectcodec.DefaultTagName + "V1"}, maxSize) |
There was a problem hiding this comment.
lc2 seemed very confusing here... because this is version 1.
|
|
||
| c = codec.NewManager(maxSize) | ||
| // for backward compatibility, still register the initial codec version |
There was a problem hiding this comment.
This isn't really for backwards compatibility... I think this was a remnant of a prior design for the stop vertex codec handling.
dhrubabasu
approved these changes
Dec 29, 2023
JacobEverly
approved these changes
Dec 29, 2023
darioush
approved these changes
Dec 29, 2023
pull bot
pushed a commit
to AKAJOKER2/avalanchego
that referenced
this pull request
Jan 1, 2024
Co-authored-by: Stephen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This standardizes how we use the reflect codec and simplifies some code paths.
How this works
It's essentially a pure refactor.
How this was tested