Standardize onShutdownCtx
#2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
abi87,
danlaine and
StephenButtolph
as code owners
dhrubabasu
commented
Dec 31, 2023
| startShutdown context.CancelFunc | ||
| awaitShutdown sync.WaitGroup | ||
| // Cancelled on shutdown | ||
| onShutdownCtx context.Context |
There was a problem hiding this comment.
This technically is not needed in the VM struct for this PR. In a follow-up, we'll use it to cleanup the mempool pruner: #2566
StephenButtolph
approved these changes
Dec 31, 2023
patrick-ogrady
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This feels more readable to me
How this works
mostly renames
How this was tested
CI