[utils/bloom] Optionally Update Bloom Filter Size on Reset #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
requested review from
danlaine,
joshua-kim and
StephenButtolph
as code owners
patrick-ogrady
changed the title
ceyonur
reviewed
Jan 10, 2024
ceyonur
reviewed
Jan 10, 2024
ceyonur
reviewed
Jan 10, 2024
StephenButtolph
approved these changes
Jan 10, 2024
ceyonur
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
If the size of items that a bloom filter is tracking increases above the expected number, it can trigger frequent resets. We should instead grow the bloom filter to maintain the same target false positive probability.
How this works
Modifies reset logic to grow the bloom filter if the number of target items grows.
Related: ava-labs/coreth#452
How this was tested
CI