Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip bloom metrics #2614

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add ip bloom metrics #2614

merged 2 commits into from
Jan 16, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

Adds observability into the efficiency of the new IP bloom tracking.

How this works

Adds various metrics.

How this was tested

  • Fuji:
# HELP avalanche_network_validator_ips Number of known validator IPs
# TYPE avalanche_network_validator_ips gauge
avalanche_network_validator_ips 305
# HELP avalanche_network_gossipable_ips Number of IPs this node is willing to gossip
# TYPE avalanche_network_gossipable_ips gauge
avalanche_network_gossipable_ips 280
# HELP avalanche_network_ip_bloom_count Number of IP entries added to the bloom
# TYPE avalanche_network_ip_bloom_count gauge
avalanche_network_ip_bloom_count 305
# HELP avalanche_network_ip_bloom_entries Number of entry slots in the IP bloom
# TYPE avalanche_network_ip_bloom_entries gauge
avalanche_network_ip_bloom_entries 2247
# HELP avalanche_network_ip_bloom_hashes Number of hashes in the IP bloom
# TYPE avalanche_network_ip_bloom_hashes gauge
avalanche_network_ip_bloom_hashes 10
# HELP avalanche_network_ip_bloom_max_count Maximum number of IP entries that can be added to the bloom before resetting
# TYPE avalanche_network_ip_bloom_max_count gauge
avalanche_network_ip_bloom_max_count 1792
# HELP avalanche_network_ip_bloom_reset_count Number times the IP bloom has been reset
# TYPE avalanche_network_ip_bloom_reset_count counter
avalanche_network_ip_bloom_reset_count 4

with:

# HELP avalanche_network_peers Number of network peers
# TYPE avalanche_network_peers gauge
avalanche_network_peers 280

@StephenButtolph StephenButtolph added the monitoring This primarily focuses on logs, metrics, and/or tracing label Jan 16, 2024
@StephenButtolph StephenButtolph added this to the v1.10.18 milestone Jan 16, 2024
@StephenButtolph StephenButtolph self-assigned this Jan 16, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 16, 2024
Merged via the queue into dev with commit 003ed7f Jan 16, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the add-ip-bloom-metrics branch January 16, 2024 15:10
marun pushed a commit that referenced this pull request Jan 17, 2024
chand1012 pushed a commit to multisig-labs/avalanchego that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring This primarily focuses on logs, metrics, and/or tracing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants