Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify all MockGen generated files are re-generated in CI #2616

Merged
merged 29 commits into from
Jan 17, 2024

Conversation

dhrubabasu
Copy link
Contributor

@dhrubabasu dhrubabasu commented Jan 16, 2024

Why this should be merged

All files that are generated by mockgen should be re-generated by our up-to-dates mock check. This PR does that.

How this works

  • Populate an array of outputted_files as we go through scripts/mocks.mockgen.source.txt and scripts/mocks.mockgen.txt.
  • Use grep to get an array of generated_files.
  • Verify that there is no diff between them.

How this was tested

CI

@dhrubabasu dhrubabasu added the ci This focuses on changes to the CI process label Jan 16, 2024
@dhrubabasu dhrubabasu added this to the v1.10.18 milestone Jan 16, 2024
@dhrubabasu dhrubabasu self-assigned this Jan 16, 2024
@dhrubabasu dhrubabasu marked this pull request as draft January 16, 2024 21:27
@dhrubabasu dhrubabasu changed the title Delete all mocks first in CI check Verify all MockGen generated files are re-generated in CI Jan 16, 2024
@dhrubabasu dhrubabasu marked this pull request as ready for review January 17, 2024 03:05
Base automatically changed from mockgen-source to dev January 17, 2024 17:33
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 17, 2024
Merged via the queue into dev with commit cde054f Jan 17, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the delete-all-mocks-first branch January 17, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants