ACP-77: Update SecondsUntil to prevent under-charging
#3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samliok
approved these changes
Sep 18, 2024
ARR4N
reviewed
Sep 18, 2024
| if err != nil || totalSeconds >= maxSeconds { | ||
| if err != nil { | ||
| // This is technically unreachable, but makes the code more | ||
| // clearly correct. | ||
| return maxSeconds |
There was a problem hiding this comment.
As above re 0 instead of maxSeconds
There was a problem hiding this comment.
If this value were to overflow, it would mean that maxSeconds should be retuned. 0 would not be correct to return (if this value weren't well defined, we'd need to return an error rather than an ambiguous 0)
There was a problem hiding this comment.
Similar clarification to above - this function is essentially implementing:
"If you need to pay $x every second, how long does $y last? If the answer is more than z then just say 1 minute."
If $x would last longer than MaxUint64, returning 0 is incorrect. We should return 1 minute.
ARR4N
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Undercharging -> DoS
Overcharging -> Happy
Also limits fuzzing to an hour rather than a year. With race detection enabled, running for a full year can take too long.
How this works
SecondsUntil->SecondsRemainingThe block timestamp must only be able to advance to a point that validators are fully paying for that time.
How this was tested