Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] Fix bootstrap monitor e2e image build error check #3443

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Oct 3, 2024

testify was panicking on the previous error check which was preventing diagnosis of the underlying cause of image build flakes.

testify was panicking on the previous error check which was preventing
diagnosis of the underlying cause of the image build failure.
@marun marun added the testing This primarily focuses on testing label Oct 3, 2024
@marun marun self-assigned this Oct 3, 2024
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is going to fix the issue - but the code looks better this way

@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit 43d5b43 Oct 3, 2024
23 checks passed
@StephenButtolph StephenButtolph deleted the test-fix-bm-e2e-output-string branch October 3, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants