Evict recentlyAccepted blocks based on wall-clock time #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
force-pushed
the
evict-blocks-wallclock
branch
from
123b8dd to
f492247
Compare
iansuvak
commented
Oct 11, 2024
StephenButtolph
approved these changes
Oct 14, 2024
joshua-kim
approved these changes
Oct 16, 2024
ceyonur
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In combination with ACP-115 this would remove requirements for issuing dummy transaction on P-Chain for ACP-77 flows on networks that don't have frequent P-Chain block production like Fuji and Devnet.
How this works
Changes
RWLocktoLockand evicts nodes based on wall-clock time on all operations.The
Windowis used here in validators.Manager and the change affects the output ofManager.GetMinimumHeightHow this was tested
Modified existing test cases from negative to positive cases since the behavior of the window is changing here.