Unexport all P-Chain visitors #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
changed the base branch from
master
to
remove-p-chain-txsmock-package
StephenButtolph
changed the title
yacovm
approved these changes
Nov 7, 2024
joshua-kim
approved these changes
Nov 7, 2024
marun
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
While using visitors rather than type switches enforces handling of all possible transaction types, instantiating a visitor is very annoying.
How this works
Rather than having callers create the visitor and then passing the visitor into the
Visitfunction, this PR abstracts the visitor behind a function.How this was tested
This is a pure refactor, the existing tests should ensure the correctness of this change.
Need to be documented in RELEASES.md?
No.