[tmpnet] Misc cleanup for monitoring tooling #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- monitoring scripts output the command to kill the collector they start - make script output uniformly cased - write the monitoring url for a local node and tmpnet nodes to their respective node paths for later use
yacovm
reviewed
Nov 7, 2024
|
|
||
| // Write link to the network path and to stdout | ||
| metricsPath := filepath.Join(n.Dir, "metrics.txt") | ||
| if err := os.WriteFile(metricsPath, []byte(metricsURL+"\n"), perms.ReadWrite); err != nil { |
There was a problem hiding this comment.
perms.ReadWrite this is genius!
yacovm
approved these changes
Nov 7, 2024
|
It seems like the intent is for this to be written exactly as written, without evaluating any expressions. |
StephenButtolph
approved these changes
Nov 7, 2024
|
Ah - it is causing CI to fail |
|
Updated to ignore shellcheck failures, since the intent is to output the literal rather than evaluated version of the text. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Cleanup DX for local monitoring in preparation for lightning talk.
How this works
How this was tested
Manually
Need to be documented in RELEASES.md?
No