Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logging.Format to expose constants #3561

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

Allows referencing constants rather than hard-coded values.

How this works

Adds a few variables.

How this was tested

N/A

Need to be documented in RELEASES.md?

No.

@StephenButtolph StephenButtolph added monitoring This primarily focuses on logs, metrics, and/or tracing cleanup Code quality improvement labels Nov 21, 2024
@StephenButtolph StephenButtolph added this to the v1.11.14 milestone Nov 21, 2024
@StephenButtolph StephenButtolph self-assigned this Nov 21, 2024
Copy link
Contributor

@marun marun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had already updated 3557, next time please warn me so we don't duplicate effort!

config/flags.go Outdated Show resolved Hide resolved
@StephenButtolph StephenButtolph added this pull request to the merge queue Nov 21, 2024
Merged via the queue into master with commit dbf95e0 Nov 21, 2024
23 checks passed
@StephenButtolph StephenButtolph deleted the antithesis-json-logs branch November 21, 2024 18:50
@StephenButtolph StephenButtolph modified the milestones: v1.11.14, v1.12.0 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement monitoring This primarily focuses on logs, metrics, and/or tracing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants