Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSON logs during Antithesis runs #3562

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Nov 21, 2024

Why this should be merged

Currently the antithesis tests perform string matching rather than looking at log levels.

How this works

Sets the log format to json.

How this was tested

Manually:

avalanche-node-1          | {"level":"trace","timestamp":"2024-11-21T19:39:31.316Z","logger":"P Chain","caller":"snowman/topological.go:594","msg":"accepting block","blkID":"RQSTTsQ9WAurX8M8fiDt6injR3GtiUETEDjHyDLT7L9uhAYBc","height":1,"timestamp":"2024-11-21T19:39:31.000Z"}

The logs for the nodes (not the workload) are now json 🥳

Need to be documented in RELEASES.md?

No.

@StephenButtolph StephenButtolph added the testing This primarily focuses on testing label Nov 21, 2024
@StephenButtolph StephenButtolph added this to the v1.11.14 milestone Nov 21, 2024
@StephenButtolph StephenButtolph self-assigned this Nov 21, 2024
Base automatically changed from antithesis-json-logs to master November 21, 2024 18:50
Copy link
Contributor

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@StephenButtolph StephenButtolph added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit 5f70e7b Nov 22, 2024
23 checks passed
@StephenButtolph StephenButtolph deleted the antithesis-json-logs-2 branch November 22, 2024 17:31
@StephenButtolph StephenButtolph modified the milestones: v1.11.14, v1.12.0 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants