Antithesis: Skip checks if tx confirmation fails #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
testing
|
Are you looking to see this merged before or after the zap PR? |
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
|
I'm happy to rebase this on top of the zap PR |
marun
approved these changes
Nov 21, 2024
StephenButtolph
changed the base branch from
master
to
testing-switch-to-zap
marun
approved these changes
Nov 21, 2024
marun
approved these changes
Nov 22, 2024
samliok
reviewed
Nov 22, 2024
| ) | ||
| return | ||
| } | ||
|
|
||
| w.verifyXChainTxConsumedUTXOs(ctx, operationTx) |
There was a problem hiding this comment.
should this method be refactored to return an error? It seems to just log an error if one occurs during but then returns nothing.
I could create a follow up PR if so
There was a problem hiding this comment.
Because this function doesn't actually perform any modifications, it isn't required to propagate the error up... So that's why I didn't include that in this PR... But it certainly could.
samliok
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The Antithesis tests have been consistently failing because the workload incorrectly skips transaction confirmation.
Specifically:
Errors this PR should resolve:
failed to verify that X-chain UTXO was deletedfailed to verify that P-chain UTXO was deletedHow this works
If the transaction confirmation check is cancelled, we do not perform verification of the expected state transition.
How this was tested
Ran locally and didn't see any regressions.
Need to be documented in RELEASES.md?
No.