Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused wallet interface #3568

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

We only have one struct that implements the Wallet interface, we can just pass around a struct.

How this works

Removes the interface and exports the struct.

How this was tested

CI

Need to be documented in RELEASES.md?

No.

@StephenButtolph StephenButtolph added the cleanup Code quality improvement label Nov 25, 2024
@StephenButtolph StephenButtolph added this to the v1.11.14 milestone Nov 25, 2024
@StephenButtolph StephenButtolph self-assigned this Nov 25, 2024
@StephenButtolph StephenButtolph merged commit 5a75231 into master Nov 25, 2024
23 checks passed
@StephenButtolph StephenButtolph deleted the remove-unused-wallet-interface branch November 25, 2024 22:41
@StephenButtolph StephenButtolph modified the milestones: v1.11.14, v1.12.0 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants