Improve block building and verification logging #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
the
monitoring
aaronbuchwald
approved these changes
Dec 17, 2024
| @@ -44,7 +45,7 @@ func (s State) AdvanceTime( | |||
| func (s State) ConsumeGas(gas Gas) (State, error) { | |||
| newCapacity, err := safemath.Sub(uint64(s.Capacity), uint64(gas)) | |||
| if err != nil { | |||
| return State{}, ErrInsufficientCapacity | |||
| return State{}, fmt.Errorf("%w: capacity (%d) < gas (%d)", ErrInsufficientCapacity, s.Capacity, gas) | |||
Comment on lines
+358
to
+360
| builder.txExecutorBackend.Ctx.Log.Warn("failed to pack block transactions", | ||
| zap.Error(err), | ||
| ) |
There was a problem hiding this comment.
Note: engine will log at debug, but not warn level since block build failures can happen regularly if the VM cleared its mempool and decides not to produce an empty block.
iansuvak
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Makes debugging issues easier.
How this works
Adds logs and formats errors.
How this was tested
N/A
Need to be documented in RELEASES.md?
No.