Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Static Fee Config #3610

Merged
merged 34 commits into from
Jan 12, 2025
Merged

Remove Static Fee Config #3610

merged 34 commits into from
Jan 12, 2025

Conversation

samliok
Copy link
Contributor

@samliok samliok commented Dec 18, 2024 •
edited
Loading

Why this should be merged

After the Etna update there is no longer use for the staticFeeConfig as well as the static fee calculator. This PR removes these structs as well as cleans up the surrounding tests and configs.

How this works

How this was tested

CI/CD

Need to be documented in RELEASES.md?

Yes

@samliok samliok self-assigned this Dec 18, 2024
@samliok samliok marked this pull request as draft December 18, 2024 19:13
@samliok samliok marked this pull request as ready for review December 18, 2024 23:04
@samliok samliok mentioned this pull request Dec 19, 2024
Closed
@samliok samliok linked an issue Dec 19, 2024 that may be closed by this pull request
update GetTxFee endpoint in service.go #3611
Closed
StephenButtolph
StephenButtolph reviewed Dec 27, 2024
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
vms/avm/client.go Outdated Show resolved Hide resolved
vms/platformvm/config/internal.go Outdated Show resolved Hide resolved
vms/platformvm/txs/fee/static_config.go Outdated Show resolved Hide resolved
wallet/chain/p/builder/builder.go Outdated Show resolved Hide resolved
wallet/chain/p/builder/context.go Outdated Show resolved Hide resolved
StephenButtolph
StephenButtolph reviewed Jan 3, 2025
View reviewed changes
config/flags.go Show resolved Hide resolved
vms/platformvm/txs/executor/import_test.go Outdated Show resolved Hide resolved
wallet/chain/p/builder_test.go Show resolved Hide resolved
vms/platformvm/txs/fee/calculator_test.go Outdated Show resolved Hide resolved
vms/platformvm/txs/executor/standard_tx_executor_test.go Outdated Show resolved Hide resolved
StephenButtolph
StephenButtolph reviewed Jan 11, 2025
View reviewed changes
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for commenting after approval / saying it lgtm... But I think we need to add the API changes to the release notes

api/info/service.go Show resolved Hide resolved
vms/avm/service.go Show resolved Hide resolved
@samliok
Update RELEASES.md
7378450 
Signed-off-by: Sam Liokumovich <[email protected]>
@marun marun added this pull request to the merge queue Jan 12, 2025
Merged via the queue into master with commit acec94c Jan 12, 2025
22 checks passed
@marun marun deleted the static-fee-remove branch January 12, 2025 01:52
tsachiherman pushed a commit that referenced this pull request Jan 29, 2025
@samliok @meaghanfitzgerald
@StephenButtolph @tsachiherman
Remove Static Fee Config (#3610)
7bbd993 
Signed-off-by: Sam Liokumovich <[email protected]>
Co-authored-by: Meaghan FitzGerald <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@marun marun marun approved these changes

@meaghanfitzgerald meaghanfitzgerald Awaiting requested review from meaghanfitzgerald meaghanfitzgerald is a code owner

Assignees

@samliok samliok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update GetTxFee endpoint in service.go
4 participants
@samliok @marun @StephenButtolph @meaghanfitzgerald