chore(ci): define Github labels as code with a workflow #3629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/github/labels-as-code
branch
from
8c76133 to
d5310ae
Compare
- exact same labels as existing ones - allow for future tracked modifications of labels - labels workflow dry-runs on PRs
qdm12
force-pushed
the
qdm12/github/labels-as-code
branch
from
d5310ae to
b3607e7
Compare
marun
approved these changes
Jan 2, 2025
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: crazy-max/ghaction-github-labeler@v5 |
There was a problem hiding this comment.
We haven't typically used "less trusted" 3rd parties like this. What are the guarantees around which repository secrets are provided to jobs like this?
There was a problem hiding this comment.
GitHub Actions can only read a secret if you explicitly include the secret in a workflow.
Seems like it should be fine.
There was a problem hiding this comment.
Yep 😉 It may not always had been the case, so good checking!
crazy-max does a lot of things in the docker/CI space, you may see his username around again!
StephenButtolph
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Allow to track in source control the Github labels, and to easily migrate Github labels (i.e. renames).
This might be extended to the coreth and subnet-evm repositories in order to add/change labels in a source controlled/reviewable way.
How this works
New Github workflow
.github/workflows/labels.ymlusinggithub/labels.ymlas a source for the labels. All the label data was extracted from this API call to keep it the exact same.How this was tested
Dry run of labeler job on this PR.
Need to be documented in RELEASES.md?
No