Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BLS healthcheck to communicate incorrect BLS key configuration #3638

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

One of the more common misconfigurations for avalanchego is to have misconfigured the BLS signer. This adds a healthcheck that attempts to warn that this has happened.

It isn't guaranteed to work (as the node may not actually consider itself as part of the validator set even though the rest of the network does). However, this check should have no false positives after bootstrapping has finished.

How this works

Adds another health check that verifies that the node's BLS key matches the key that was registered under the node's ID.

How this was tested

Ran locally:

[01-04|17:33:57.810] WARN health/worker.go:252 check started failing {"name": "health", "name": "bls", "tags": ["application"], "error": "node has BLS key 0xb42bd7dc7d21372a7612f78d4279a44e64c0f75f10f73d84f1a88ffac2e646fa4b95d97ceac33a846fbb8cd2618e20d6, but is registered to the validator set with 0xa3783a891cb41cadbfcf456da149f30e7af972677a162b984bef0779f254baac51ec042df1781d1295df80fb41c80126"}

Need to be documented in RELEASES.md?

N/A

@StephenButtolph StephenButtolph added the monitoring This primarily focuses on logs, metrics, and/or tracing label Jan 4, 2025
@marun marun added this pull request to the merge queue Jan 5, 2025
Merged via the queue into master with commit 7efd463 Jan 5, 2025
22 checks passed
@marun marun deleted the add-bls-health-check branch January 5, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring This primarily focuses on logs, metrics, and/or tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants