[ci] Use go env {GOOS,GOARCH} for os and arch detection #3661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
commented
Jan 19, 2025
yacovm
approved these changes
Jan 19, 2025
marun
force-pushed
the
cleanup-arch-detection
branch
from
3238788 to
854d3c0
Compare
1 task
StephenButtolph
approved these changes
Jan 27, 2025
tsachiherman
pushed a commit
that referenced
this pull request
Jan 29, 2025
Co-authored-by: Maru Newby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Some scripts were discovering the os and arch of tools to install in unnecessarily complicated ways. Switching them to use the simpler
go env GOOSandgo env GOOARCHmethods.How this was tested
CI
Need to be documented in RELEASES.md?
N/A