[spike] Refactor TestIssueAtomicTxs as an integration test #377

marun · 2023-11-03T19:44:02Z

Why this should be merged

This refactor is intended to demonstrate the potential of writing integration tests against a fixture interface that can be implemented by both a bare VM and a network API. This should support more comprehensive test coverage for minimal additional cost.

How this works

TestIssueAtomicTxs is factored into test code and fixture. The test is intended to be configured at runtime to use a VM or network fixture.

How this was tested

A new integration test suite that includes the refactored test is executed in CI (via scripts/tests.integration.sh) as part of the unit test job (with vm fixture) and a new integration test job (with network fixture).

TODO

Add validation to atomic transaction execution in shared network fixture
Merge Switch to using require.TestingT interface in SenderTest struct avalanchego#2258
Merge e2e: Refactor suite setup and helpers to tests/fixture/e2e for reuse by coreth avalanchego#2265
e2e: More fixture refinement in support of coreth integration testing avalanchego#2275
Fix failure of integration tests in windows unit test job
Update version and dep pin for avalanchego to a released version

scripts/versions.sh

.github/workflows/ci.yml

plugin/evm/shared_test_vm_fixture.go

…fixture

darioush · 2024-03-18T20:07:23Z

plugin/evm/vm_test.go

-	assert.Equal(t, uint64(2), height, "expected height of indexed export tx to be 2")
-	assert.Equal(t, indexedExportTx.ID(), exportTx.ID(), "expected ID of indexed import tx to match original txID")
-}
-
 func TestBuildEthTxBlock(t *testing.T) {


I think we should be confident that the fixture can interface with most if not all the tests in vm_test.go vm_warp_test.go, (eg, do some of these instantiate more than 1 vm?)
Some of the tests in syncervm_test.go are also candidates, but somewhat a stretch goal.

darioush · 2024-03-18T20:09:37Z

tests/integration/fixture.go

+	var fixture IntegrationFixture
+	if e2e.Env == nil {
+		// Shared network fixture not initialized, return a vm fixture
+		fixture = evm.CreateVMFixture(ginkgo.GinkgoT())


smaller comment: Should we consider calling the light (VM) fixture from the unit tests? This would continue running them with race detection, and on the different OS-es.

darioush · 2024-03-18T20:10:07Z

I like what this change achieves. I think it makes sense to run the "VM-level unit tests" against a full node.
I think we should try to develop on subnet-evm first for this change (or see if the same style applies).

marun · 2024-07-10T04:53:14Z

This has been paused indefinitely and its compatibility with the intended fork maintenance strategy is uncertain. Closing for now, but leaving the branch in case someone wants to pick it up in the future.

marun mentioned this pull request Nov 3, 2023

Switch to using require.TestingT interface in SenderTest struct ava-labs/avalanchego#2258

Merged

marun force-pushed the vm-integration-fixture branch from b001053 to ab74f52 Compare November 6, 2023 19:40

marun mentioned this pull request Nov 6, 2023

e2e: Refactor suite setup and helpers to tests/fixture/e2e for reuse by coreth ava-labs/avalanchego#2265

Merged

marun force-pushed the vm-integration-fixture branch from 58dd28a to b384047 Compare November 8, 2023 13:25

marun commented Nov 8, 2023

View reviewed changes

scripts/versions.sh Outdated Show resolved Hide resolved

marun mentioned this pull request Nov 8, 2023

e2e: More fixture refinement in support of coreth integration testing ava-labs/avalanchego#2275

Merged

1 task

marun force-pushed the vm-integration-fixture branch 2 times, most recently from c1a8164 to 8746622 Compare November 8, 2023 20:21

marun assigned aaronbuchwald Nov 13, 2023

marun added testing Anything testing-related integration-testing Refactoring of unit tests to fixture-based integration labels Nov 13, 2023

marun assigned marun and unassigned aaronbuchwald Nov 13, 2023

marun force-pushed the vm-integration-fixture branch 3 times, most recently from 308266a to 923dc81 Compare November 20, 2023 17:07

marun force-pushed the vm-integration-fixture branch 2 times, most recently from 4fe7024 to 4843b22 Compare December 1, 2023 00:32

marun marked this pull request as ready for review December 1, 2023 00:45

marun requested review from aaronbuchwald, darioush and ceyonur as code owners December 1, 2023 00:45

marun force-pushed the vm-integration-fixture branch 3 times, most recently from 420e05a to 8860ccd Compare December 1, 2023 13:59

ceyonur reviewed Dec 4, 2023

View reviewed changes

marun marked this pull request as draft December 4, 2023 17:23

marun changed the title ~~Refactor TestIssueAtomicTxs as an integration test~~ [spike] Refactor TestIssueAtomicTxs as an integration test Dec 4, 2023

marun marked this pull request as ready for review December 15, 2023 06:32

marun marked this pull request as draft December 15, 2023 06:42

marun added 19 commits March 14, 2024 20:03

Enable bootstrap check on shared network fixture teardown

84ae56a

Update export amount to account for dynamic fees with shared network …

6cd7564

…fixture

Add node restart check on teardown

365e7ae

Revert CORETH_PATH definition in scripts/tests.e2e.sh

4d029f3

Rename tests/integration/integration.go -> tests/integration/fixture.go

bfd1a3d

Ensure avalanche build script fetches tags for an existing clone

e0d24ea

Run the integration test binary directly for compatibility with windows

895e366

Attemp to work around ancient bash version in macos unit test machine

834668a

Try to fix macos compilation failure

7707ea1

fixup: Rename prefunded -> pre-funded

4b3702c

fixup: Get tests passing

9630b61

fixup: Update fixture use to latest tmpnet

e8d8e6c

fixup: go mod tidy

218e61c

fixup: Responded to review feedback

4830341

fixup: Fix broken unit test

3d7070e

fixup: Add CheckBootstrapIsPossible until available in tagged release

0736144

fixup: Update to use network.StartNode for teardown check

a3c9b31

fixup: Simplify fixture teardown registration

a988f86

fixup: Respond to review feedback

e9ba3d7

marun force-pushed the vm-integration-fixture branch from e1b330b to e9ba3d7 Compare March 15, 2024 03:08

marun added 3 commits March 14, 2024 20:28

fixup: Fix compilation errors and reconcile changes to vm_test.go

71176ad

fixup: ensure consistent go version in ci

2036a23

fixup: Address shellcheck issues

7aa10c6

darioush reviewed Mar 18, 2024

View reviewed changes

marun mentioned this pull request Mar 29, 2024

Remove AddEphemeralNode ava-labs/avalanchego#2887

Merged

darioush pushed a commit that referenced this pull request Apr 25, 2024

Migrate replay protection bypass for Nick's Method Signature txs (#377)

652572e

marun closed this Jul 10, 2024

marun mentioned this pull request Jul 31, 2024

[e2e] Enhance post-test bootstrap checks ava-labs/avalanchego#3253

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[spike] Refactor TestIssueAtomicTxs as an integration test #377

[spike] Refactor TestIssueAtomicTxs as an integration test #377

marun commented Nov 3, 2023 •

edited

Loading

darioush Mar 18, 2024

darioush Mar 18, 2024

darioush commented Mar 18, 2024

marun commented Jul 10, 2024

[spike] Refactor TestIssueAtomicTxs as an integration test #377

[spike] Refactor TestIssueAtomicTxs as an integration test #377

Conversation

marun commented Nov 3, 2023 • edited Loading

Why this should be merged

How this works

How this was tested

TODO

darioush Mar 18, 2024

Choose a reason for hiding this comment

darioush Mar 18, 2024

Choose a reason for hiding this comment

darioush commented Mar 18, 2024

marun commented Jul 10, 2024

marun commented Nov 3, 2023 •

edited

Loading